[PATCH] D148921: [llvm-exegesis] Use MCJIT only for execution

Thu Apr 27 01:03:38 PDT 2023

kpdev42 marked an inline comment as done.
kpdev42 added inline comments.

================
Comment at: llvm/tools/llvm-exegesis/lib/Assembler.cpp:348
+#ifndef NDEBUG
+  auto Address = Functions.front().getAddress();
+  assert(Address && *Address == 0 && "Unexpected layout");
----------------
courbet wrote:
> I'm not very familiar with the section API, is this the relative address of the symbol within the section or an absolute address ? If the latter should this be compared to `SectionRef::getAddress()` rather than 0 ?
You are most probably right, because these addresses are subtracted in https://github.com/llvm/llvm-project/blob/main/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp#L177

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148921/new/

https://reviews.llvm.org/D148921