[PATCH] D149061: [clang] remove dereferencing of invalid pointer

Wed Apr 26 13:29:11 PDT 2023

nickdesaulniers added a comment.

In D149061#4297011 <https://reviews.llvm.org/D149061#4297011>, @ashay-github wrote:

> In D149061#4292974 <https://reviews.llvm.org/D149061#4292974>, @nickdesaulniers wrote:
>
>> It would have been good to include your test case though.
>
> Ah, I forgot to mention that the error was also reproducible using an existing test (the one in clang/test/CodeGenCXX/mangle-nttp-anon-union.cpp).  The specific case that I mentioned ("_Z5dummyIXtl8wrapper1IdEtlNS1_Ut_Edi9RightNametlNS2_Ut_ELd405ec00000000000EEEEEEvv") is just a subset of the mangle-nttp-anon-union.cpp test, specifically the lines below:
>
>   dummy<wrapper1<double>{123.0}>();
>   // CHECK: call void @_Z5dummyIXtl8wrapper1IdEtlNS1_Ut_Edi9RightNametlNS2_Ut_ELd405ec00000000000EEEEEEvv
>   // DEMANGLED: call void @void dummy<wrapper1<double>{wrapper1<double>::'unnamed'{.RightName = wrapper1<double>::'unnamed'::'unnamed'{0x1.ec{{.*}}p+6}}}>()()

Got it. Any ideas why I'm not able to reproduce on a non-windows host (and AFAIK that specific test case hasn't been flagged by any build bots)? I would think we should still be able to test the windows demangling scheme on any host.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149061/new/

https://reviews.llvm.org/D149061