[PATCH] D149268: [LLD][COFF] Fix PDB relocation on big-endian hosts

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 11:32:10 PDT 2023


aganea added inline comments.


================
Comment at: lld/COFF/PDB.cpp:958
     auto unrelocatedRvaStart = subsecData.take_front(sizeof(uint32_t));
     uint8_t relocatedRvaStart[sizeof(uint32_t)];
     debugChunk->writeAndRelocateSubsection(debugChunk->getContents(),
----------------
Can't we just write `support::ulittle32_t rvaStart;` here and static cast to a uint8_t* it below in the function call?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149268/new/

https://reviews.llvm.org/D149268



More information about the llvm-commits mailing list