[PATCH] D147545: [AutoFDO] Stale profile matching(part 2)

Wed Apr 26 10:04:41 PDT 2023

wlei added a comment.

In D147545#4297736 <https://reviews.llvm.org/D147545#4297736>, @wenlei wrote:

> lgtm, thanks!
>
> As we evolve `SampleProfileMatcher`, it might be worth considering moving the matcher into its own file similar to SampleProfileProbe.cpp, to avoid bloating SampleProfile.cpp indefinitely. But this can be handled later in separate patch.

Good point, will do in a separate patch.

In D147545#4297742 <https://reviews.llvm.org/D147545#4297742>, @wenlei wrote:

> In D147545#4287782 <https://reviews.llvm.org/D147545#4287782>, @hoy wrote:
>
>> How about retitle it as "[AutoFDO] Stale profile matching (part 2)" to align with the first patch? It's mentioned in the summary that only supports CSSPGO for now, so it should be good.
>
> I found this confusing, and the patch really isn't about AutoFDO, but CSSPGO. Maybe rename the first patch as [CSSPGO] instead for consistency. Or just say SamplePGO to avoid differentiating the two.

The infra might be useful for AutoFDO, changed to SamplePGO.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147545/new/

https://reviews.llvm.org/D147545