[PATCH] D149211: [GlobalISel][InlineAsm][X86]Fallback on DAG ISel when lowering inline assembly

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D149211#4297740 <https://reviews.llvm.org/D149211#4297740>, @mingmingl wrote:

> https://gcc.godbolt.org/z/vq4nGG793 shows setting `global-isel-abort` to `DisableWithDiag` indeed works.
>
> Thinking back what I have in mind when writing this patch, I misunderstood how I shall use `fallBackToDAGISel` (thought the fallback path would also call this method )-> in fact, when IRTranslator handles translation error <https://github.com/llvm/llvm-project/blob/7f96ce5e133be54891af177adbf8952d413e0f85/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp#L238>, it sets properties on machine-function; and let codegen pass builder to decide whether to restore machine function and falls back to selection-dag-based ISel (decided by `-global-isel-abort` mode)

IIRC the only reason that exists was for a compile time hack for common cases that would fall back.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149211/new/

https://reviews.llvm.org/D149211