[PATCH] D149086: [lld] Use correct machine type in ARM64EC COFF headers.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 00:19:43 PDT 2023


mstorsjo accepted this revision.
mstorsjo added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/COFF/arm64ec.test:14
+RUN: llvm-readobj --hex-dump=.data test.dll | FileCheck -check-prefix=DATAEC %s
+DATAEC: 02020202
+
----------------
mstorsjo wrote:
> It’sa bit unclear what the `DATAEC` check here really verifies? I’m sure it’s relevant later on, but within the scope of this patch, this test feels mostly confusing.
Nevermind, for both comments here - it becomes quite reasonable in the next patch, and it's probably cleanest to leave this as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149086/new/

https://reviews.llvm.org/D149086



More information about the llvm-commits mailing list