[PATCH] D149192: [IR] Add interface to remove a CallBase string function attribute

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 14:15:54 PDT 2023


snehasish accepted this revision.
snehasish added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/unittests/IR/InstructionsTest.cpp:107
+  Call->addFnAttr(Attribute::get(Call->getContext(), "test-str-fn-attr"));
+  EXPECT_TRUE(Call->hasFnAttr("test-str-fn-attr"));
+  Call->removeFnAttr("test-str-fn-attr");
----------------
ASSERT_TRUE since it doesn't make sense to continue if we fail here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149192/new/

https://reviews.llvm.org/D149192



More information about the llvm-commits mailing list