[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string&

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: lld/ELF/Symbols.cpp:50
+    std::string root = symName.str();
+    return demangle(root);
+  }
----------------
MaskRay wrote:
> `return demangle(symName.str());`
> 
> perhaps `return demangle(symName);` works as well?
> perhaps return demangle(symName); works as well?

I saw test failures with that change.  I can keep it as is; wasn't sure if it's worth making this more obvious...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149104/new/

https://reviews.llvm.org/D149104