[PATCH] D149021: [TTI][ASAN] Introduce TTI::getInterstingMemoryOperand.

Yeting Kuo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 23 19:56:18 PDT 2023


fakepaper56 added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:32
 #include "llvm/Support/InstructionCost.h"
+#include "llvm/Transforms/Instrumentation/AddressSanitizerCommon.h"
 #include <functional>
----------------
arichardson wrote:
> This looks like a layering violation? I don't think analysis can depend on this?
Thank you for your reminder. I think we could create a new file "llvm/Support/InterestingMemoryOperand.h" to move `InterestingMemoryOperand` out. Do you think it is a good idea?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149021/new/

https://reviews.llvm.org/D149021



More information about the llvm-commits mailing list