[PATCH] D149008: [InstSimplify] Test for D149001

Zhu Siyuan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 23 00:01:26 PDT 2023


floatshadow added a comment.

In D149008#4290189 <https://reviews.llvm.org/D149008#4290189>, @junaire wrote:

> This doesn't look right. I don't know how other people do this, but below is my regular workflow:
>
>   # Let's say you have a commit A and you need to split a part of it to B, which is a commit before A
>   git reset HEAD^ # This unstaged all your changes to A
>   git add -p . # add changes you want to split
>   git commit # This is the commit B
>   git add -p . # add the rest of your changes
>   git commit # This is the commit A
>   # Now do git log you can see you have B --> A 
>   git reset --hard HEAD^ # jump to commit B because arc only uploads the top one commit
>   arc diff # Create revision B, then add a child revision, which is your old revision of your folds
>   git reset --hard xxxx # jump back to A, you can use git reflog to find the commit hash
>   arc diff --update xxx # update your old revision

Thank you for your reply. I am not familiar with parent/child chain. I will try a fix later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149008/new/

https://reviews.llvm.org/D149008



More information about the llvm-commits mailing list