[PATCH] D148980: [X86] Machine combine vnni instruction.

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCombiner.cpp:173
+    }
+  }
   // PHI's have no depth etc.
----------------
What is this change for?


================
Comment at: llvm/lib/CodeGen/MachineCombiner.cpp:424
+  unsigned NewRootLatency = TSchedModel.computeInstrLatency(InsInstrs.back());
+  unsigned RootLatency = TSchedModel.computeInstrLatency(Root);
 
----------------
This seems like an unrelated change. Can you split it?


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:9822
+      DelInstrs.push_back(&Root);
+      break;
+    }
----------------
Maybe this belongs in `X86FixupInstTuning.cpp`?


================
Comment at: llvm/test/CodeGen/X86/avxvnni-combine.ll:4
+
+; __m256i foo(int cnt, __m256i c, __m256i b, __m256i *p) {
+;     for (int i = 0; i < cnt; ++i) {
----------------
Can you precommit the test so we can see the diff?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148980/new/

https://reviews.llvm.org/D148980