[PATCH] D148877: [PGO]Implement metadata combine for 'branch_weights' of direct callsites

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 01:21:47 PDT 2023


nikic added inline comments.


================
Comment at: llvm/test/Transforms/SimplifyCFG/merge-direct-call-branch-weights-in-hoist.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
+; RUN: opt < %s -passes='simplifycfg<no-sink-common-insts;hoist-common-insts>' -simplifycfg-require-and-preserve-domtree=1 -S | FileCheck %s --check-prefix=HOIST
----------------
You need `--check-globals` to check the resulting metadata. Also, it should be possible to reduce these tests to basically an if/else with a call each.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148877/new/

https://reviews.llvm.org/D148877



More information about the llvm-commits mailing list