[PATCH] D145168: Move DBG_VALUE's that depend on loads to after a load if the load is moved due to the pre register allocation ld/st optimization pass

Shubham Sandeep Rastogi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 11:32:30 PDT 2023


rastogishubham updated this revision to Diff 515407.
rastogishubham marked an inline comment as done.
rastogishubham added a comment.

Removed the include "llvm/CodeGen/MachineInstr.h" in DebugInfoMetadata.h

Added a new test to check to make sure that DBG_VALUEs that use an immediate are not zero-ed out if another DBG_VALUE is seen later

I created a static function

  createDebugVariableFromMachineInstr

to create a DebugVariable, because I was not sure if I could add an include to DebugInfoMetadata.h in the MachineInstr.h file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145168/new/

https://reviews.llvm.org/D145168

Files:
  llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp
  llvm/test/DebugInfo/ARM/move-dbg-value-after-value-list.mir
  llvm/test/DebugInfo/ARM/move-dbg-value-lists.mir
  llvm/test/DebugInfo/ARM/move-dbg-value-same-reg.mir
  llvm/test/DebugInfo/ARM/move-dbg-values-imm-test.mir
  llvm/test/DebugInfo/ARM/move-dbg-values.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145168.515407.patch
Type: text/x-patch
Size: 59125 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230420/bac35308/attachment.bin>


More information about the llvm-commits mailing list