[PATCH] D148194: [TableGen] Reduce the amount of storage space used for AddrSpaces in TypeSetByHwMode. NFC

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:86-88
+  // Take the address space from the first type in the list.
+  if (!VTList.empty())
+    AddrSpace = VTList[0].PtrAddrSpace;
----------------
I've never really understood TypeSetByHwMode. Currently the address space would largely be unused since it doesn't actually work in SelectionDAG. Would this stop you from parameterizing the same pattern over multiple address spaces, or just swapping out the address space based on the hwmode?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148194/new/

https://reviews.llvm.org/D148194