[PATCH] D148186: ValueTracking: Handle insertelement in computeKnownFPClass

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks OK modulo nits.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4128
                          const TargetLibraryInfo *TLI) {
+  assert(Known.isUnknown() && "should not be called with known information");
+
----------------
Wouldn't it be simpler to make all these computeKnownFPClass functions return KnownFPClass?


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4606-4607
   auto *FVTy = dyn_cast<FixedVectorType>(V->getType());
   APInt DemandedElts =
       FVTy ? APInt::getAllOnes(FVTy->getNumElements()) : APInt(1, 1);
   ::computeKnownFPClass(V, DemandedElts, InterestedClasses, Known, Depth,
----------------
Could call your new computeKnownFPClass overload rather than repeating this logic?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148186/new/

https://reviews.llvm.org/D148186