[PATCH] D148509: [BranchFolder] Skip redundant IMPLICIT_DEFs of subregs

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 03:57:29 PDT 2023


foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/CodeGen/BranchFolding.cpp:866
+        // TODO: Common this up with the same logic in addLineIns().
+        bool ContainsSuperReg = false;
+        for (MCSuperRegIterator SReg(Reg, TRI); SReg.isValid(); ++SReg) {
----------------
Pierre-vh wrote:
> small nit: isn't there a way to do this more succinctly with `any_of`?
Yes using superregs(). It seems mc_superreg_iterator was intended to replace MCSuperRegIterator but it never happened.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148509/new/

https://reviews.llvm.org/D148509



More information about the llvm-commits mailing list