[PATCH] D148446: [X86][tablgen] Remove predicates for definitions of KMOV b/c due to no pattern, NFCI

Sat Apr 15 21:17:29 PDT 2023

skan added a comment.

In D148446#4271702 <https://reviews.llvm.org/D148446#4271702>, @craig.topper wrote:

> In D148446#4271692 <https://reviews.llvm.org/D148446#4271692>, @skan wrote:
>
>> In D148446#4271665 <https://reviews.llvm.org/D148446#4271665>, @craig.topper wrote:
>>
>>> Could this information be useful to other tools in the future.
>>
>> I'm not very sure, I think there is basically no probability of using it because tools should need CPUID instead of predicate. Predicate does not exactly correspond to CPUID, for example we have predicate `NoAVX512`, `NoAVX` and `NoVLX_Or_NoVAES`. I am trying to remove these predicates b/c they affect the test coverage.
>
> How do they affect the test coverage?

No test fails after removing the predicates. So these code is untested.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148446/new/

https://reviews.llvm.org/D148446