[PATCH] D148445: [libunwind] Remove the legacy Unwind_AppleExtras.cpp

[Louis Dionne via Phabricator via llvm-commits]

ldionne added inline comments.


================
Comment at: libunwind/src/Unwind_AppleExtras.cpp:63-82
-NOT_HERE_BEFORE_10_6(_Unwind_DeleteException)
-NOT_HERE_BEFORE_10_6(_Unwind_Find_FDE)
-NOT_HERE_BEFORE_10_6(_Unwind_ForcedUnwind)
-NOT_HERE_BEFORE_10_6(_Unwind_GetGR)
-NOT_HERE_BEFORE_10_6(_Unwind_GetIP)
-NOT_HERE_BEFORE_10_6(_Unwind_GetLanguageSpecificData)
-NOT_HERE_BEFORE_10_6(_Unwind_GetRegionStart)
----------------
I am very confident this isn't useful anymore.


================
Comment at: libunwind/src/Unwind_AppleExtras.cpp:88-94
-NEVER_HERE(__register_frame_info_bases)
-NEVER_HERE(__register_frame_info)
-NEVER_HERE(__register_frame_info_table_bases)
-NEVER_HERE(__register_frame_info_table)
-NEVER_HERE(__register_frame_table)
-NEVER_HERE(__deregister_frame_info)
-NEVER_HERE(__deregister_frame_info_bases)
----------------
These ones I have a bit more doubt. I think either we don't care about hiding those anymore, or we do but in that case the current annotations are out of date, since they only hide the symbols for `os10.4`, `os10.5` and `os10.6`, which is far from the only "os"es released by Apple.


================
Comment at: libunwind/src/Unwind_AppleExtras.cpp:106-119
-NOT_HERE_BEFORE_5_0(_Unwind_GetLanguageSpecificData)
-NOT_HERE_BEFORE_5_0(_Unwind_GetRegionStart)
-NOT_HERE_BEFORE_5_0(_Unwind_GetIP)
-NOT_HERE_BEFORE_5_0(_Unwind_SetGR)
-NOT_HERE_BEFORE_5_0(_Unwind_SetIP)
-NOT_HERE_BEFORE_5_0(_Unwind_DeleteException)
-NOT_HERE_BEFORE_5_0(_Unwind_SjLj_Register)
----------------
I am very confident this isn't useful anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148445/new/

https://reviews.llvm.org/D148445