[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

Jan Sjödin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 16:41:41 PDT 2023


jsjodin added inline comments.


================
Comment at: mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h:174
+        if (offloadMod.getIsDevice()) {
+          hostIRFilePath = offloadMod.getHostIRFilePath();
+        }
----------------
agozillon wrote:
> This will break the patch buildbot unfortunately until the patch this patch is dependent on is accepted and upstreamed
> This will break the patch buildbot unfortunately until the patch this patch is dependent on is accepted and upstreamed

You can always skip this part and add it in a separate patch, or add it in a patch where it is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148370/new/

https://reviews.llvm.org/D148370



More information about the llvm-commits mailing list