[PATCH] D148309: [AArch64] Change the type of i64 neon shifts to v1i64

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 01:30:50 PDT 2023


dmgreen created this revision.
dmgreen added reviewers: jaykang10, SjoerdMeijer, efriedma, bipmis.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
dmgreen requested review of this revision.
Herald added a project: LLVM.

This alters the lowering of shifts by a constant, so that the type is lowered to a v1i64 instead of a i64. This helps communicate that the type will live in a neon register, and can help clean up surrounding code. Note this is only currently for the scalar shifts of a constant that go through the nodes in tryCombineShiftImm.

ssra instructions are no longer being recognized in places, but that can be cleaned up in a followup patch that combines the i64 add into a v1i64 add.


https://reviews.llvm.org/D148309

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/test/CodeGen/AArch64/arm64-vshift.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148309.513470.patch
Type: text/x-patch
Size: 4486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230414/b60729f9/attachment.bin>


More information about the llvm-commits mailing list