[PATCH] D145884: test-release.sh: build projects and runtimes lists with semicolons

Thu Apr 13 04:55:51 PDT 2023

mstorsjo added a subscriber: phosek.
mstorsjo added a comment.

In D145884#4262759 <https://reviews.llvm.org/D145884#4262759>, @dim wrote:

> So this seems to have been caused by @mstorsjo 's rG8368e4d54c459fe173d76277f17c632478e91add <https://reviews.llvm.org/rG8368e4d54c459fe173d76277f17c632478e91add>, which added:
>
>   set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
>
> to `compiler-rt/lib/builtins/CMakeLists.txt`. Because this line is there, the checks in CMAKE_DETERMINE_COMPILER_ABI don't run the linker, and this CMake functionality needs to see linker output lines to determine the actual ABI, in this case `x86_64-linux-gnu`.

CC @phosek - since that change does seem to be causing issues, should we perhaps revert it? (This would require me to revert https://github.com/mstorsjo/llvm-mingw/commit/056cb22fb537e392d525b869f92699441704a78b downstream, to start passing `-DCMAKE_C_COMPILER_WORKS=1` when building the builtins again - but that shouldn't be any problem.)

In D145884#4262759 <https://reviews.llvm.org/D145884#4262759>, @dim wrote:

> Because `CMAKE_LIBRARY_ARCHITECTURE` isn't set, the `find_library()` calls for e.g. zlib (but also other libraries) fail to search `/usr/lib/x86_64-linux-gnu` (or other ABI specific library paths).

I've seen this issue wrt `CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY` before, but I'm wondering how it ends up here in this case. Since we're only setting `CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY` while configuring specifically `compiler-rt/lib/builtins`, I presume there's nothing that looks for zlib within that? Or does the runtimes build somehow reuse caches for later stages, so that the builtins stage which didn't detect that part of the architecture, ends up breaking later stages?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145884/new/

https://reviews.llvm.org/D145884