[PATCH] D148212: [Assignment Tracking][SelectionDAG] Downgrade dbg.assigns to dbg.values if assignment tracking is not enabled

[Jeremy Morse via Phabricator via llvm-commits]

jmorse requested changes to this revision.
jmorse added a comment.
This revision now requires changes to proceed.

The test wants a triple, plus I have a question about the checks.



================
Comment at: llvm/test/DebugInfo/assignment-tracking/X86/assignment-tracking-not-enabled.ll:1-2
+; RUN: llc %s -stop-after=finalize-isel -o - \
+; RUN: | FileCheck %s --implicit-check-not=DBG_
+
----------------
I think the triple needs to present on the command line or in the ll file, otherwise we'll hit buildbots that support x86 but where it isn't the default triple, and we'll get different output.


================
Comment at: llvm/test/DebugInfo/assignment-tracking/X86/assignment-tracking-not-enabled.ll:4-6
+;; Check that SelectionDAG downgrades dbg.assigns to dbg.values if assignment
+;; tracking isn't enabled (e.g. if the module flag
+;; "debug-info-assignment-tracking" is missing / false).
----------------
What would the debug-info output look like with AT, and do we need to CHECK-NOT it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148212/new/

https://reviews.llvm.org/D148212