[PATCH] D148049: [llvm-objdump] Add --markup-context to adjust VMAs.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 00:05:53 PDT 2023


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/tools/llvm-objdump/X86/markup-context.test:63
+Sections:
+  # Demonstrates basic dissembly address adjustment
+  - Name:            .text
----------------
Nit: most new tests in llvm-objdump use `##` for comments. Comments should also end with a "."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148049/new/

https://reviews.llvm.org/D148049



More information about the llvm-commits mailing list