[PATCH] D147980: Emit unwind information in .debug_frame section when .cfi_sections .debug_frame intrinsic is used

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:1910
     if (CanOmitDwarf && Frame.CompactUnwindEncoding !=
-          MOFI->getCompactUnwindDwarfEHFrameOnly())
-      // Don't generate an EH frame if we don't need one. I.e., it's taken care
-      // of by the compact unwind encoding.
+          MOFI->getCompactUnwindDwarfEHFrameOnly() && IsEH)
+      // Don't generate an EH frame if we don't need one and location of unwind
----------------
I still find this sentence confusing.

Does this convey what you want to say?
```
Don't generate eh_frame if it's not needed. It's not needed if either eh_frame isn't requested or if we can use compact unwind instead.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147980/new/

https://reviews.llvm.org/D147980