[PATCH] D137707: Move "auto-init" instructions to the dominator of their users

Wed Apr 12 13:48:52 PDT 2023

MaskRay added a comment.

In D137707#4261118 <https://reviews.llvm.org/D137707#4261118>, @hans wrote:

> It's actually worse than my repro above showed. Since "real" initialization of the sret arg can get folded in with the "auto" initialization, this patch can also cause an actually initialized return value to become uninitialized: https://bugs.chromium.org/p/chromium/issues/detail?id=1431366#c8
>
> I'll revert this for now.

This is from `clang --target=i686-linux-gnu`. @serge-sans-paille Testing `-m32` applications will create a lot of `sret` opportunities (structs are unions are indirect, even if small) and sort out such bugs.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137707/new/

https://reviews.llvm.org/D137707