[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 09:24:08 PDT 2023


zequanwu added a comment.

In D147256#4261949 <https://reviews.llvm.org/D147256#4261949>, @hans wrote:

>> Well, MSVC cl removes redundant dots so we shouldn't remove llvm::sys::path::remove_dots.
>
> Could we do the `remove_dots` on the Clang side, where we can decide based on the LangOpts?

Yes, we can do that. Is there a reason to favor there over here? At here, the object path in llc output can also benefits from `remove_dots`, not just clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147256/new/

https://reviews.llvm.org/D147256



More information about the llvm-commits mailing list