[PATCH] D148023: [X86][FastISel] Handle CRC32 intrinsics

[Alexis Engelke via Phabricator via llvm-commits]

aengelke added inline comments.


================
Comment at: llvm/test/CodeGen/X86/crc32-intrinsics-fast-isel-x86_64.ll:8
+; Note: %a1 is i32 as FastISel can't handle i8/i16 arguments.
+define i32 @test_mm_crc32_u8(i32 %a0, i32 %a1) nounwind{
+; CHECK-LABEL: test_mm_crc32_u8:
----------------
RKSimon wrote:
> RKSimon wrote:
> > Please can you add a crc32-intrinsics-fast-isel-x86.ll file and put theses 32-bit tests there (with 32-bit and 64-bit targets test coverage).
> Add test_mm_crc64_u8 back with the i64 arg + trunc trick 
Done, but not sure whether this is the best place to test this, `llvm.x86.sse42.crc32.64.8` is just an auto-upgrade to `x86_sse42_crc32_32_8`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148023/new/

https://reviews.llvm.org/D148023