[PATCH] D129173: [RISCV] Remove debug location to spill/reload instructions

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 19:21:20 PDT 2023


benshi001 added a comment.

My suggestion,

1. improve your commit info, something like

  Spill/reload instructions are artificially generated by the compiler and
  have no relation to the original source code. So the best thing to do is
  not attach any debug location to them (instead of just taking the next
  debug location we find on following instructions).
  
  Refered to https://reviews.llvm.org/rG3e081703c349dd00b8ef6991c2d15964915dd8f4



2. add some tests as you did in your another review request.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129173/new/

https://reviews.llvm.org/D129173



More information about the llvm-commits mailing list