[PATCH] D148001: [LICM] Reassociate & hoist add/sub expressions

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 02:54:50 PDT 2023


mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:2591
+  ICmp->setOperand(1, NewCmpOp);
+  cast<Instruction>(LHS)->eraseFromParent();
+  return true;
----------------
Should have used `eraseInstruction`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148001/new/

https://reviews.llvm.org/D148001



More information about the llvm-commits mailing list