[PATCH] D145884: test-release.sh: build projects and runtimes lists with semicolons

[Amy Kwan via Phabricator via llvm-commits]

amyk added a comment.

On Power, I am seeing extra LIT failures after applying this patch that did not happen before:

  AddressSanitizer-powerpc64le-linux :: TestCases/Linux/malloc_delete_mismatch.cpp
  AddressSanitizer-powerpc64le-linux-dynamic :: TestCases/Linux/malloc_delete_mismatch.cpp
  MemorySanitizer-POWERPC64LE :: Linux/sigandorset.cpp
  SanitizerCommon-asan-powerpc64le-Linux :: onprint.cpp
  SanitizerCommon-tsan-powerpc64le-Linux :: onprint.cpp
  UBSan-AddressSanitizer-powerpc64le :: TestCases/Misc/Linux/diag-stacktrace.cpp
  UBSan-MemorySanitizer-powerpc64le :: TestCases/Misc/Linux/diag-stacktrace.cpp
  UBSan-Standalone-powerpc64le :: TestCases/Misc/Linux/diag-stacktrace.cpp
  UBSan-ThreadSanitizer-powerpc64le :: TestCases/Misc/Linux/diag-stacktrace.cpp

As well as object file differences (that appear to occur every time):

  # Comparing Phase 2 and Phase 3 files
  file Process.cpp.o differs between phase 2 and phase 3
  file CRC.cpp.o differs between phase 2 and phase 3
  file Compression.cpp.o differs between phase 2 and phase 3
  file llvm-config.cpp.o differs between phase 2 and phase 3

It looks like these are all related to not being able to find ZLIB for whatever reason, as I can see in the new test failures similar messages along the lines of:

  . . . 
          2: error: failed to decompress '.debug_aranges', LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time
           3: error: failed to decompress '.debug_info', LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time
           4: error: failed to decompress '.debug_abbrev', LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time
           5: error: failed to decompress '.debug_line', LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time
           6: error: failed to decompress '.debug_str', LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time
           7: error: failed to decompress '.debug_loc', LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time
           8: error: failed to decompress '.debug_ranges', LLVM was not built with LLVM_ENABLE_ZLIB or did not find zlib at build time
  . . . 

I think this makes sense, as I can even see on the Phase 3 of building LLVM, the following message during configuration:

  -- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")

Whereas I get a message for Phase 3 saying that the ZLIB library was found (prior to building with this patched version of `test-release.sh`).

In any case, I just wanted to quickly follow up and report with the testing results that I did with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145884/new/

https://reviews.llvm.org/D145884