[PATCH] D147504: [WebAssembly] `AsmTypeCheck` support to br instr

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 9 06:23:45 PDT 2023


aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp:204
+  WebAssemblyAsmOperandFrame::OperandStack EnterStack =
+      BrStack.back().getEnterStack();
+  for (wasm::ValType VT : llvm::reverse(LastSig.Params))
----------------
aheejin wrote:
> TODO aheejin copy? do we use this later again?
Sorry, forgot to remove my own memo here, and Phabricator doesn't give a way to delete inline comments... Please ignore the message above. By the way, a question: this looks copying the stack intentionally not to modify `BrStack.back().EnterStack`, correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147504/new/

https://reviews.llvm.org/D147504



More information about the llvm-commits mailing list