[PATCH] D147709: Rename llvm/utils/TableGen/X86ManualFoldTables.def to .inc

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni abandoned this revision.
chapuni added a comment.

@GMNGeoffrey This was the first change to add `.def` to the executable, aka `cc_binary`, AFAIK.
I wanted to stop it since it was the first issue that was added recently.

I know we shouldn't work something for the convenience of bazel.
As you can guess, "Win32's module def" was just my 2nd excuse.

I think since rGff1b820c7d0cd46f024c0d93a0994e6f5996cc16 <https://reviews.llvm.org/rGff1b820c7d0cd46f024c0d93a0994e6f5996cc16> is sufficient, I would make adding header libraries in the future for similar issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147709/new/

https://reviews.llvm.org/D147709