[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

Erich Keane via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 7 09:53:26 PDT 2023


erichkeane added a comment.

I don't see much value in these changes.  In the cases I know anything about, the change in state (or out params) is the error checking that we need.  The casts add nothing but noise, so I don't think these are good changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147791/new/

https://reviews.llvm.org/D147791



More information about the llvm-commits mailing list