[PATCH] D147662: [LoopPredication] Fix where we generate widened condition. PR61963

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 07:38:41 PDT 2023


anna added inline comments.


================
Comment at: llvm/test/Transforms/LoopPredication/pr61963.ll:11
+; CHECK-NEXT: %widenable_cond11 = call i1 @llvm.experimental.widenable.condition
+define i32 @foo(ptr addrspace(3) %arg) !prof !0 {
+bb:
----------------
mkazantsev wrote:
> Is it possible to reduce the test via bugpoint? Just assert whenever you move non-loop-invariant into loop in this transform and let it do the job.
Yea, I had reduced this with bugpoint using exactly similar assert. The problem is it removes all the deopt calls as well and makes it oversimplified (we can see the problem, but it's not that clear, since the deopt states are missing). I can hack bug point to avoid removing these deopt calls. Will try that or manually reducing this further.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147662/new/

https://reviews.llvm.org/D147662



More information about the llvm-commits mailing list