[PATCH] D147645: [InstCombine] Sink bin op into select if first or second value is simplified to constant

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 12:23:07 PDT 2023


xbolva00 updated this revision to Diff 511183.
xbolva00 added a comment.

Do not perform this optimization with bools as there are infinite instcombine loops.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147645/new/

https://reviews.llvm.org/D147645

Files:
  llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
  llvm/test/Transforms/InstCombine/and-or-icmps.ll
  llvm/test/Transforms/InstCombine/and2.ll
  llvm/test/Transforms/InstCombine/binop-select.ll
  llvm/test/Transforms/InstCombine/icmp-add.ll
  llvm/test/Transforms/InstCombine/max_known_bits.ll
  llvm/test/Transforms/InstCombine/minmax-demandbits.ll
  llvm/test/Transforms/InstCombine/not.ll
  llvm/test/Transforms/InstCombine/rem.ll
  llvm/test/Transforms/InstCombine/select-2.ll
  llvm/test/Transforms/InstCombine/sub-ashr-or-to-icmp-select.ll
  llvm/test/Transforms/InstCombine/subtract-from-one-hand-of-select.ll
  llvm/test/Transforms/InstCombine/subtract-of-one-hand-of-select.ll
  llvm/test/Transforms/InstCombine/widenable-conditions.ll
  llvm/test/Transforms/InstCombine/with_overflow.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147645.511183.patch
Type: text/x-patch
Size: 77672 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230405/f209968a/attachment.bin>


More information about the llvm-commits mailing list