[PATCH] D147526: [sanitizers] Simplify Explainer about dyld and weak overrides on Darwin. (NFC)
Roy Sundahl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 4 12:04:43 PDT 2023
rsundahl updated this revision to Diff 510881.
rsundahl added a comment.
Added some suggested comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147526/new/
https://reviews.llvm.org/D147526
Files:
llvm/docs/ReleaseNotes.rst
Index: llvm/docs/ReleaseNotes.rst
===================================================================
--- llvm/docs/ReleaseNotes.rst
+++ llvm/docs/ReleaseNotes.rst
@@ -245,16 +245,14 @@
only consider symbols in other mach-o modules which themselves contain at
least one weak symbol. A consequence is that if your program or dylib contains
an intended override of a weak symbol, then it must contain at least one weak
- symbol as well for the override to be effective. That weak symbol may be the
- intended override itself, an otherwise usused weak symbol added solely to meet
- the requirement, or an existing but unrelated weak symbol.
-
- Examples:
- __attribute__((weak)) const char * __asan_default_options(void) {...}
+ symbol as well for the override to take effect.
+ Example:
+ // Add this to make sure your override takes effect
__attribute__((weak,unused)) unsigned __enableOverrides;
-
- __attribute__((weak)) bool unrelatedWeakFlag;
+
+ // Example override
+ extern "C" const char *__asan_default_options() { ... }
Other Changes
-------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147526.510881.patch
Type: text/x-patch
Size: 1119 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230404/960fec40/attachment.bin>
More information about the llvm-commits
mailing list