[PATCH] D147348: [MergedLoadStoreMotion] Merge stores with conflicting value types

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 09:01:51 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp:266
+  IRBuilder<> Builder(S0);
+  auto Cast = Builder.CreateBitOrPointerCast(S0->getValueOperand(),
+                                             S1->getValueOperand()->getType());
----------------
This should not introduce addrspacecast. I’m assuming this is filtered by isBitOrNoopPointerCastable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147348/new/

https://reviews.llvm.org/D147348



More information about the llvm-commits mailing list