[PATCH] D147340: [Support] Improve Windows performance of buffered raw_ostream

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

In D147340#4240456 <https://reviews.llvm.org/D147340#4240456>, @aganea wrote:

> Sounds good!
> I'm just curious, have you tried experimenting with different sizes? Would it make sense to set a higher value for the mapfile using `.SetBufferSize()`?

Yes, I did experiment with different sizes on a variety of PCs and the 16KB size was the "sweet" spot for these systems. On one, there were very minor gains from going larger but I decided it was not worthwhile, at least for the "preferred" size. A larger buffer could be set for LLD symbol map generation but the best part of the gains are already realized with the 16KB buffer size for my test systems.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147340/new/

https://reviews.llvm.org/D147340