[PATCH] D146325: [PowerPC] Add statistics to show the number of entries in the TOC.

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:470-472
+  // If this is a new TOC entry add statistics about it.
+  if (!TOC.contains({Sym, Kind}))
+    collectTOCStats(Type);
----------------
Just out of curiosity, why couldn't this have been added to the conditional block on line 476?


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-TOC-stats.ll:3
+;;        run a script to update these checks.
+
+; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff -mcpu=pwr8 \
----------------
Don't you need something like `REQUIRES asserts` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146325/new/

https://reviews.llvm.org/D146325