[PATCH] D110900: Triple: Add RedHat vendor

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 06:38:00 PDT 2023


tstellar added inline comments.


================
Comment at: llvm/include/llvm/TargetParser/Triple.h:579
+    case Triple::UnknownEnvironment:
+        return getVendor() == RedHat;
+    default:
----------------
aaronpuchert wrote:
> hvdijk wrote:
> > In D110900#4160169 you suggested that this should be done for SUSE as well, do you still think so?
> Yes, in fact we ship with a [patch](https://build.opensuse.org/package/view_file/devel:tools:compiler/llvm16/llvm-suse-implicit-gnu.patch) that does that in openSUSE now. It mostly works without that, but some things were missing, see D110900#4160110.
> 
> If we can agree on this, I'd open a separate change on top of this for `SUSE`. (Unless @tstellar would like to include it right away.)
I think we should add SUSE here in a separate change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110900/new/

https://reviews.llvm.org/D110900



More information about the llvm-commits mailing list