[PATCH] D147132: [FuncSpec] Replace markArgInFuncSpecialization with handleCallArguments.

[Momchil Velikov via Phabricator via llvm-commits]

chill added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SCCPSolver.cpp:836
 
-void SCCPInstVisitor::markArgInFuncSpecialization(
-    Function *F, const SmallVectorImpl<ArgInfo> &Args) {
----------------
I understand that with this change we will propagate literal constant arguments into the specialized functions. But, going forward, we intend to enable `funcspec-for-literal-constant` by default and then this functions here has the potential to be more efficient.

Thus I would suggest not deleting it for now.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147132/new/

https://reviews.llvm.org/D147132