[PATCH] D147368: [LoongArch] Optimize bitwise and with immediates

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 1 00:23:16 PDT 2023


xen0n accepted this revision.
xen0n added a comment.
This revision is now accepted and ready to land.

Good catch, thanks!

IMO you could include as comments your explanations to existing cases where this optimization has not taken place (e.g. "This is not optimized into `bstrpick + slli` because the constant has multiple uses."), so future readers wouldn't have to do archaeology to see them. The code changes LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147368/new/

https://reviews.llvm.org/D147368



More information about the llvm-commits mailing list