[PATCH] D145872: TableGen: Let expressions available to list subscripts and list slices

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added a reviewer: arsenm.
chapuni added inline comments.
Herald added a subscriber: wdng.


================
Comment at: llvm/docs/TableGen/ProgRef.rst:527
 
+    *value*\ ``[i,m...n,j,ls]``
+        Each element may be an expression (variables, bang operators).
----------------
arsenm wrote:
> This section is indented further than the others 
It is intentional that this is the subitem as supplement, since I wanted to avoid rewriting whole this item.
Could I rewrote this flat? Or I am happy if you could suggest an alternative sentense.


================
Comment at: llvm/lib/TableGen/TGParser.cpp:760
+
+  assert(RHS);
+  assert(isa<IntRecTy>(RHS->getType()));
----------------
arsenm wrote:
> This assert seems redundant with the cast<> above 
I intend this as catching `RHS = nullptr` by default.
Assignments are done in L738 and L752, and I would like to catch the assumption after cases in the switch (in the future).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145872/new/

https://reviews.llvm.org/D145872