[PATCH] D147212: [ARM] Handle generating SEH unwind info for t2STR_PRE/t2LDR_POST

Thu Mar 30 13:59:07 PDT 2023

efriedma added a comment.

In D147212#4234854 <https://reviews.llvm.org/D147212#4234854>, @mstorsjo wrote:

>> I'm assuming the load/store ops are getting generated by expanding a PUSH/POP, and not some other transform?  (So the offset will actually reliably be 4, in practice?)
>
> Not sure actually - if looking at the output of `-print-after-all` here, the `t2STR_PRE` appears as such directly, not as a transformation of something else - I don't directly see where it comes from (other than printf instrumenting the code in Target/ARM to see which reference to `t2STR_PRE` gets hit).

Skimming the code, it looks like it's coming out of ARMFrameLowering::emitPushInst... which should be safe in that respect.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147212/new/

https://reviews.llvm.org/D147212