[PATCH] D147060: [MachineSink] Fix an assertion failure in isCycleInvariant

antoine moynault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 09:06:54 PDT 2023


antmo added a comment.

Thanks again for the review @jmorse. I modified the test.

I think the break statement cannot be removed, as it would crash if the last instruction is a debug instruction. Please correct me if I am missing something here.

Also I cannot merge the patch myself. So if everything is OK, could someone do this for me please?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147060/new/

https://reviews.llvm.org/D147060



More information about the llvm-commits mailing list