[PATCH] D142231: [AMDGPU][AsmParser] Refine SMRD offset definitions.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 09:22:13 PDT 2023


kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:759
 
+def SMRDLiteralOffsetClass : NamedMatchClass<"SMRDLiteralOffset", 0> {
+  let ParserMethod = "";
----------------
dp wrote:
> I assume making this operand optional or mandatory does not really affect anything, does it?
`isSMRDLiteralOffset()` reads like it can't really be optional.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142231/new/

https://reviews.llvm.org/D142231



More information about the llvm-commits mailing list