[PATCH] D147159: [AMDGPU][GFX940] Simplify definitions of GLOBAL_ATOMIC

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 07:57:31 PDT 2023


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:725-727
   defm FLAT_ATOMIC_ADD_F64   : FLAT_Atomic_Pseudo<"flat_atomic_add_f64", VReg_64, f64>;
   defm FLAT_ATOMIC_MIN_F64   : FLAT_Atomic_Pseudo<"flat_atomic_min_f64", VReg_64, f64>;
   defm FLAT_ATOMIC_MAX_F64   : FLAT_Atomic_Pseudo<"flat_atomic_max_f64", VReg_64, f64>;
----------------
Can you also remove the predicate for these FLAT Reals? Or is there some reason why that would not work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147159/new/

https://reviews.llvm.org/D147159



More information about the llvm-commits mailing list