[PATCH] D147124: [lld][ELF][NFC] Simplify "Thunk *elf::addThunk(...)"

[Ben Shi via Phabricator via llvm-commits]

benshi001 created this revision.
benshi001 added a reviewer: MaskRay.
Herald added subscribers: arichardson, emaste.
Herald added a project: All.
benshi001 requested review of this revision.
Herald added subscribers: llvm-commits, jacquesguan.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147124

Files:
  lld/ELF/Thunks.cpp


Index: lld/ELF/Thunks.cpp
===================================================================
--- lld/ELF/Thunks.cpp
+++ lld/ELF/Thunks.cpp
@@ -1312,20 +1312,23 @@
   Symbol &s = *rel.sym;
   int64_t a = rel.addend;
 
-  if (config->emachine == EM_AARCH64)
+  switch (config->emachine) {
+  case EM_AARCH64:
     return addThunkAArch64(rel.type, s, a);
 
-  if (config->emachine == EM_ARM)
+  case EM_ARM:
     return addThunkArm(rel.type, s, a);
 
-  if (config->emachine == EM_MIPS)
+  case EM_MIPS:
     return addThunkMips(rel.type, s);
 
-  if (config->emachine == EM_PPC)
+  case EM_PPC:
     return addThunkPPC32(isec, rel, s);
 
-  if (config->emachine == EM_PPC64)
+  case EM_PPC64:
     return addThunkPPC64(rel.type, s, a);
 
-  llvm_unreachable("add Thunk only supported for ARM, Mips and PowerPC");
+  default:
+    llvm_unreachable("add Thunk only supported for ARM, Mips and PowerPC");
+  }
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147124.509251.patch
Type: text/x-patch
Size: 909 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230329/6b6badc8/attachment.bin>