[PATCH] D146851: [support] Revise ScopedPrinter formatting tests for floats

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 27 09:21:40 PDT 2023


paulkirth added a comment.

In D146851#4223843 <https://reviews.llvm.org/D146851#4223843>, @ro wrote:

> In D146851#4223144 <https://reviews.llvm.org/D146851#4223144>, @jhenderson wrote:
>
>> LGTM, but should get the AIX/Solaris people have verified the fix.
>
> I've tested the fix on Solaris/amd64: the test still `PASS`es.  Thanks.

Thanks for taking the time to do that. Sorry it took a while to get this right.

In D146851#4224023 <https://reviews.llvm.org/D146851#4224023>, @abhina.sreeskantharajan wrote:

> I've added reviewers that are more familiar with AIX

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146851/new/

https://reviews.llvm.org/D146851



More information about the llvm-commits mailing list