[PATCH] D146829: [AMDGPU] Remove unnecessary waitcnts

[Jessica Del via Phabricator via llvm-commits]

OutOfCache marked an inline comment as done.
OutOfCache added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1393
   // TODO: Use the (TSFlags & SIInstrFlags::LGKM_CNT) property everywhere.
-  if (TII->isDS(Inst) && TII->usesLGKM_CNT(Inst)) {
     if (TII->isAlwaysGDS(Inst.getOpcode()) ||
----------------
foad wrote:
> Might be better to make usesLGKM_CNT itself more accurate, by tweaking DSInstructions.td so that LGKM_CNT is set to 0 for instructions that don't use it.
Thank you! For some reason, I only found the definition of the intrinsic. I did not know there was a separate .td file for DS Instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146829/new/

https://reviews.llvm.org/D146829